Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(perf) add priority queue #1144

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

dummdidumm
Copy link
Member

Give certain requests priority.
If a request doesn't have priority, we first wait 1 second to

  1. let higher priority requests get through first
  2. wait for possible document changes, which make the request wait again

This hopefully makes perceived responsiveness of the language server better. It helped in my tests, especially because semantic tokens are computed less often.
#1098, #1130, #1139

Give certain requests priority.
If a request doesn't have priority, we first wait 1 second to
1. let higher priority requests get through first
2. wait for possible document changes, which make the request wait again

This hopefully makes perceived responsiveness of the language server better
sveltejs#1098, sveltejs#1130, sveltejs#1139
@dummdidumm dummdidumm merged commit 7760021 into sveltejs:master Aug 24, 2021
@dummdidumm dummdidumm deleted the perf-improvements branch August 24, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant